Repository navigation
Say a hex replaces the project's files where it does - #1440
Merged
Merged
Conversation
The add files tooltip promised a new project. Without the projects database, and in iframe controller mode, a hex replaces the open project's files instead.
|
Preview build will be at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Files tab's "Add files…" tooltip said a hex file opens as a new project. That is untrue without the projects database (no IndexedDB, or it failed to open) and in iframe controller mode, where a hex replaces the open project's files.
Those modes now get a second string,
add-files-hover-replace: "Add Python or other files to your project. A hex file replaces all project files." The choice uses the existinguseProjectsDatabaseActive(), which is false in both.The new string needs uploading to Crowdin.
Todo